DZone
Thanks for visiting DZone today,
Edit Profile
  • Manage Email Subscriptions
  • How to Post to DZone
  • Article Submission Guidelines
Sign Out View Profile
  • Post an Article
  • Manage My Drafts
Over 2 million developers have joined DZone.
Log In / Join
Refcards Trend Reports Events Over 2 million developers have joined DZone. Join Today! Thanks for visiting DZone today,
Edit Profile Manage Email Subscriptions Moderation Admin Console How to Post to DZone Article Submission Guidelines
View Profile
Sign Out
Refcards
Trend Reports
Events
Zones
Culture and Methodologies Agile Career Development Methodologies Team Management
Data Engineering AI/ML Big Data Data Databases IoT
Software Design and Architecture Cloud Architecture Containers Integration Microservices Performance Security
Coding Frameworks Java JavaScript Languages Tools
Testing, Deployment, and Maintenance Deployment DevOps and CI/CD Maintenance Monitoring and Observability Testing, Tools, and Frameworks
Partner Zones AWS Cloud
by AWS Developer Relations
Culture and Methodologies
Agile Career Development Methodologies Team Management
Data Engineering
AI/ML Big Data Data Databases IoT
Software Design and Architecture
Cloud Architecture Containers Integration Microservices Performance Security
Coding
Frameworks Java JavaScript Languages Tools
Testing, Deployment, and Maintenance
Deployment DevOps and CI/CD Maintenance Monitoring and Observability Testing, Tools, and Frameworks
Partner Zones
AWS Cloud
by AWS Developer Relations
Building Scalable Real-Time Apps with AstraDB and Vaadin
Register Now

Trending

  • Is Podman a Drop-in Replacement for Docker?
  • The SPACE Framework for Developer Productivity
  • Unlocking the Power of AIOps: Enhancing DevOps With Intelligent Automation for Optimized IT Operations
  • A Complete Guide to AWS File Handling and How It Is Revolutionizing Cloud Storage

Trending

  • Is Podman a Drop-in Replacement for Docker?
  • The SPACE Framework for Developer Productivity
  • Unlocking the Power of AIOps: Enhancing DevOps With Intelligent Automation for Optimized IT Operations
  • A Complete Guide to AWS File Handling and How It Is Revolutionizing Cloud Storage

Code Review Matters and Manners [Video]

Maria Khalusova will share some observations, thoughts and practical tricks on how to give and receive feedback without turning a code review into a battlefield.

Trisha Gee user avatar by
Trisha Gee
·
Sep. 24, 16 · Opinion
Like (4)
Save
Tweet
Share
2.57K Views

Join the DZone community and get the full member experience.

Join For Free

Abstract

A code review is basically a technical discussion that should lead to improvements in the code and/or shared knowledge in a team. As with any conversation, it should have substance and form.

What’s involved in a good code review? What kind of problems do we want to spot and address? Trisha Gee talks about things a reviewer may consider when looking at changes: what potential issues to look for, why certain patterns may be harmful, and, of course, what NOT to look at.

But when it comes to commenting on someone’s work, it may be hard to find the right words to convey a useful message without offending the authors. After all, this is something that they worked hard on. Maria Khalusova shares some observations, thoughts and practical tricks on how to give and receive feedback without turning a code review into a battlefield.

The Talk

More Information

Books

  • What to Look for in a Code Review - Trisha Gee (free!)
  • Code Complete: A Practical Handbook of Software Construction, Second Edition
    - Steve McConnell
  • Clean Code: A Handbook of Agile Software Craftsmanship - Robert C. Martin

Articles

  • What to look for in a Code Review, the article that started all of this.
  • What to look for in a Code Review: Tests
  • What to look for in a Code Review: Performance
  • What to look for in a Code Review: Data Structures
  • What to look for in a Code Review: SOLID Principles
  • What to look for in a Code Review: Security
  • What to look for in a Code Review: Upsource Quick Wins
  • What to look for in: Java 8 code
  • Code Reviews: Just Do It
  • What we learned from Google: code reviews aren’t just for catching bugs
  • The Human Cost of Tech Debt
  • How to Pick Your Battles on a Software Team

And, Of Course…

  • You can download Upsource. It’s free for up to 10 users.

Published at DZone with permission of Trisha Gee, DZone MVB. See the original article here.

Opinions expressed by DZone contributors are their own.

Trending

  • Is Podman a Drop-in Replacement for Docker?
  • The SPACE Framework for Developer Productivity
  • Unlocking the Power of AIOps: Enhancing DevOps With Intelligent Automation for Optimized IT Operations
  • A Complete Guide to AWS File Handling and How It Is Revolutionizing Cloud Storage

Comments

Partner Resources

X

ABOUT US

  • About DZone
  • Send feedback
  • Careers
  • Sitemap

ADVERTISE

  • Advertise with DZone

CONTRIBUTE ON DZONE

  • Article Submission Guidelines
  • Become a Contributor
  • Visit the Writers' Zone

LEGAL

  • Terms of Service
  • Privacy Policy

CONTACT US

  • 600 Park Offices Drive
  • Suite 300
  • Durham, NC 27709
  • support@dzone.com

Let's be friends: