Over a million developers have joined DZone.

If-Then-Else Is a Code Smell

DZone's Guide to

If-Then-Else Is a Code Smell

If-then-else is a common pattern, but should it be replaced with something more elegant? What pattern can we follow? Read on to find out more and for an example.

· Java Zone ·
Free Resource

Learn how to stop testing everything every sprint and only test the code you’ve changed. Brought to you by Parasoft.

In most cases (maybe even in all of them), if-then-else can and must be replaced by a decorator or simply another object. I've been planning to write about this for almost a year but only today found a real case in my own code that perfectly illustrates the problem. So it's time to demonstrate it and explain.

Fargo (1996) by Coen Brothers
Fargo (1996) by the Coen Brothers

Take a look at the class DyTalk from yegor256/rultor and its method modify(). In a nutshell, it prevents you from saving any data to DynamoDB if there were no modifications of the XML document. It's a valid case, and it has to be validated, but the way it's implemented is simply wrong. This is how it works (an oversimplified example):

class DyTalk implements Talk {
  void modify(Collection<Directive> dirs) {
    if (!dirs.isEmpty()) {
      // Apply the modification
      // and save the new XML document
      // to the DynamoDB table.

What's wrong, you wonder? This if-then-else forking functionality doesn't really belong to this object — that's what's wrong. Modifying the XML document and saving it to the database is its functionality, while not saving anything if the modification instructions set is empty is not (it's very similar to defensive programming). Instead, there should be a decorator, which would look like this:

class QuickTalk implements Talk {
  private final Talk origin;
  void modify(Collection<Directive> dirs) {
    if (!dirs.isEmpty()) {

Now, if and when we need our talk to be more clever in situations where the list of directives is empty, we decorate it with QuickTalk. The benefits are obvious: the DyTalk class is smaller and therefore more cohesive.

I'm suggesting this simple rule: If it's possible to convert if-then-else forking to a decorator, it has to be done. If it's not done, it's a code smell. Make sense?

Get the top tips for Java developers and best practices to overcome common challenges. Brought to you by Parasoft.

decorator ,code ,rule ,functionality ,smell ,defensive programming ,programming

Published at DZone with permission of

Opinions expressed by DZone contributors are their own.

{{ parent.title || parent.header.title}}

{{ parent.tldr }}

{{ parent.urlSource.name }}