DZone
Thanks for visiting DZone today,
Edit Profile
  • Manage Email Subscriptions
  • How to Post to DZone
  • Article Submission Guidelines
Sign Out View Profile
  • Post an Article
  • Manage My Drafts
Over 2 million developers have joined DZone.
Log In / Join
Refcards Trend Reports
Events Video Library
Over 2 million developers have joined DZone. Join Today! Thanks for visiting DZone today,
Edit Profile Manage Email Subscriptions Moderation Admin Console How to Post to DZone Article Submission Guidelines
View Profile
Sign Out
Refcards
Trend Reports
Events
View Events Video Library
Zones
Culture and Methodologies Agile Career Development Methodologies Team Management
Data Engineering AI/ML Big Data Data Databases IoT
Software Design and Architecture Cloud Architecture Containers Integration Microservices Performance Security
Coding Frameworks Java JavaScript Languages Tools
Testing, Deployment, and Maintenance Deployment DevOps and CI/CD Maintenance Monitoring and Observability Testing, Tools, and Frameworks
Culture and Methodologies
Agile Career Development Methodologies Team Management
Data Engineering
AI/ML Big Data Data Databases IoT
Software Design and Architecture
Cloud Architecture Containers Integration Microservices Performance Security
Coding
Frameworks Java JavaScript Languages Tools
Testing, Deployment, and Maintenance
Deployment DevOps and CI/CD Maintenance Monitoring and Observability Testing, Tools, and Frameworks

Integrating PostgreSQL Databases with ANF: Join this workshop to learn how to create a PostgreSQL server using Instaclustr’s managed service

Mobile Database Essentials: Assess data needs, storage requirements, and more when leveraging databases for cloud and edge applications.

Monitoring and Observability for LLMs: Datadog and Google Cloud discuss how to achieve optimal AI model performance.

Automated Testing: The latest on architecture, TDD, and the benefits of AI and low-code tools.

Related

  • MuleSoft: Tactical and Strategical Role of an Application Template
  • A Better Web3 Experience: Account Abstraction From Flow (Part 1)
  • Common Problems in React Native Apps on iOS Platform: Solutions and Tips
  • How To Verify Database Connection From a Spring Boot Application

Trending

  • DZone's Article Submission Guidelines
  • How to Submit a Post to DZone
  • Agile Estimation: Techniques and Tips for Success
  • REST vs. Message Brokers: Choosing the Right Communication

Limit your abstractions: Application Events–what about change?

Oren Eini user avatar by
Oren Eini
·
Feb. 11, 12 · News
Like (0)
Save
Tweet
Share
3.15K Views

Join the DZone community and get the full member experience.

Join For Free

in my previous post, i showed an example of application events and asked what is wrong with them.

image

public class cargoinspectionserviceimpl : icargoinspectionservice 
{
  // code redacted for simplicity

 public override void inspectcargo(trackingid trackingid)
 {
    validate.notnull(trackingid, "tracking id is required");

    cargo cargo = cargorepository.find(trackingid);
    if (cargo == null)
    {
      logger.warn("can't inspect non-existing cargo " + trackingid);
      return;
    }

    handlinghistory handlinghistory = handlingeventrepository.lookuphandlinghistoryofcargo(trackingid);

    cargo.derivedeliveryprogress(handlinghistory);

    if (cargo.delivery.misdirected)
    {
      applicationevents.cargowasmisdirected(cargo);
    }

    if (cargo.delivery.unloadedatdestination)
    {
      applicationevents.cargohasarrived(cargo);
    }

    cargorepository.store(cargo);
 }
}

this is very problematic code, from my point of view, for several reasons. look at how it allocate responsibilities. iapplicationevents is supposed to execute the actual event, but deciding when to execute the event is left for the caller. i said several reasons, but this is the main one, all other flows from it.

what happen when the rules for invoking an event change? what happen when we want to add a new event?

the way this is handled is broken. it violates the open closed principle, it violates the single responsibility principle and it frankly annoys me.

can you think about ways to improve this?

i’ll discuss some in my next post.

application

Published at DZone with permission of Oren Eini, DZone MVB. See the original article here.

Opinions expressed by DZone contributors are their own.

Related

  • MuleSoft: Tactical and Strategical Role of an Application Template
  • A Better Web3 Experience: Account Abstraction From Flow (Part 1)
  • Common Problems in React Native Apps on iOS Platform: Solutions and Tips
  • How To Verify Database Connection From a Spring Boot Application

Comments

Partner Resources

X

ABOUT US

  • About DZone
  • Send feedback
  • Careers
  • Sitemap

ADVERTISE

  • Advertise with DZone

CONTRIBUTE ON DZONE

  • Article Submission Guidelines
  • Become a Contributor
  • Visit the Writers' Zone

LEGAL

  • Terms of Service
  • Privacy Policy

CONTACT US

  • 3343 Perimeter Hill Drive
  • Suite 100
  • Nashville, TN 37211
  • support@dzone.com

Let's be friends: