DZone
Java Zone
Thanks for visiting DZone today,
Edit Profile
  • Manage Email Subscriptions
  • How to Post to DZone
  • Article Submission Guidelines
Sign Out View Profile
  • Post an Article
  • Manage My Drafts
Over 2 million developers have joined DZone.
Log In / Join
  • Refcardz
  • Trend Reports
  • Webinars
  • Zones
  • |
    • Agile
    • AI
    • Big Data
    • Cloud
    • Database
    • DevOps
    • Integration
    • IoT
    • Java
    • Microservices
    • Open Source
    • Performance
    • Security
    • Web Dev
DZone > Java Zone > Why Static is Bad and How to Avoid It

Why Static is Bad and How to Avoid It

Jens Schauder user avatar by
Jens Schauder
·
Jul. 08, 13 · Java Zone · Interview
Like (7)
Save
Tweet
164.79K Views

Join the DZone community and get the full member experience.

Join For Free

Everybody who worked with a project which included a StringUtil(s) class with only static methods, raise her hand! Thought so. Are those methods bad? Probably not so much, although I had a word to say about the name, after all if a class is not a utility it isn’t useful (by the definition of Wiktionary) and we hopefully haven’t much of that kind in our projects.

But static methods turn bad, when they become more complex than the typical content of a StringUtil class. The problem is your code becomes hard wired to that static method. There is no easy way to replace the reference to the static method with something else, and if you are testing your code using automated tests, this is exactly what you want to do.

If you don’t test your code using automated tests, do something about it NOW!

Converting a static method to something easily mocked is straight forward once you’ve done it once or twice. Lets start with an example:

public class Utility{
    public static int doSomething(){
        //…
    }
}

public class Client{
    public void foo(){
        //…
        Utility.doSomething();
        //…
    }
}

The Client uses a static method in Utility and we want to get rid of that. The first step is to make the doSomethingmethod non-static. It is really as easy as removing the static modifier. Of course now the Client needs and instance ofUtility, so we just create one for now:

public class Utility{
    public int doSomething(){
        //…
    }
}

public class Client{
    public void foo(){
        //…
        new Utility().doSomething();
        //…
    }
}

Of course this doesn’t improve the situation much. We still have a static reference to the Utility class, since the constructor is just another static method. But now we can simply inject the dependency from the outside:

public class Utility{
    public int doSomething(){
        //…
    }
}

public class Client{
    private final Utility utility;

    public Client(Utility aUtility){
        utility = aUtility;
    }

    public void foo(){
        //…
        utility.doSomething();
        //…
    }
}

Now you can replace Utility by a mocked instance for tests, you can use a wrapped instance for logging or make it implement an interface and so one. Basically you are back in OO world. Of course you can use your favorite DI-Framework to inject the dependency (just make sure you do it properly), or if you don’t mind the compile time dependency you can create an alternative constructor in the Client which uses the default implementation.

Testing Dependency Interface (computing) Implementation

Published at DZone with permission of Jens Schauder, DZone MVB. See the original article here.

Opinions expressed by DZone contributors are their own.

Popular on DZone

  • IntelliJ Integration for Mockito
  • Discussing Backend for Front-End
  • Why "Polyglot Programming" or "Do It Yourself Programming Languages" or "Language Oriented Programming" sucks?
  • Create a Millisecond-Precision Time Ticks Chart with NodeJS

Comments

Java Partner Resources

X

ABOUT US

  • About DZone
  • Send feedback
  • Careers
  • Sitemap

ADVERTISE

  • Advertise with DZone

CONTRIBUTE ON DZONE

  • Article Submission Guidelines
  • MVB Program
  • Become a Contributor
  • Visit the Writers' Zone

LEGAL

  • Terms of Service
  • Privacy Policy

CONTACT US

  • 600 Park Offices Drive
  • Suite 300
  • Durham, NC 27709
  • support@dzone.com
  • +1 (919) 678-0300

Let's be friends:

DZone.com is powered by 

AnswerHub logo